Replace styles on new-user form #1706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a new structured approach to styling components. For now I'm placing the files in newcomponents/ directory but once we have replaced styles on the rest of the site the components/ directors will be removed. Individual ember components get a class and then we use mixins as functions to apply the actual styles to the page. Hopefully this gives us a bunch of re-uability without needing to put things in a global style space at all.
new-user needed access to the cohort - no idea why it was running before, probably an artifact of running after acceptance tests. new-directory-user was actually testing new-user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new structured approach to styling components. For now I'm
placing the files in newcomponents/ directory but once we have replaced
styles on the rest of the site the components/ directors will be
removed.
Individual ember components get a class and then we use mixins as
functions to apply the actual styles to the page. Hopefully this gives
us a bunch of re-uability without needing to put things in a global
style space at all.
Refs #1705